Update docker compose with Allegra compatible tags #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Dec 16, 2020
rvl
approved these changes
Dec 17, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 17, 2020
2397: Fix bug preventing txs to be listed when filter spans multiple eras r=rvl a=Anviking # Issue Number ADP-626 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Make rendering of MsgInterpreterPastHorizon more readable in logs - [x] Add regression test for ADP-626 - [x] Fix ADP-626 by wrapping `HF.Qry` in a new monad to allow safe composition (like we used to before) - [x] TODO: Adjust doc comments # Comments - Tested manually that e.g. `cardano-wallet transaction list 94962db0b6ecda7b6d1af8e2afce61b166065545 --start 2019-10-17T10:15:00Z --end 2020-12-20T10:15:00Z` (Filter including Byron, Shelley and Allegra) works. - We used to have this approach before the Allegra integration - Alternative: Replace `slotRangeFromRelativeTimeRange :: Range RelativeTime -> Qry (Range SlotNo)` with something that takes a `TimeInterpreter m` and returns `m (Range SlotNo)` - To this seems to undermine having a `Qry` monad in the first place, if the calling wallet-code cannot compose queries, or has to be careful when doing so. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2398: Update docker compose with Allegra compatible tags r=rvl a=melmccann Update docker compose to reflect the Allegra docker compatible versions 2402: Remove dead code r=rvl a=rvl ### Issue Number None ### Overview Removes dead code and outdated things, noticed while reviewing, investigating code, etc. ### Comments  Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Mel McCann <[email protected]>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 17, 2020
2398: Update docker compose with Allegra compatible tags r=rvl a=melmccann Update docker compose to reflect the Allegra docker compatible versions 2402: Remove dead code r=rvl a=rvl ### Issue Number None ### Overview Removes dead code and outdated things, noticed while reviewing, investigating code, etc. ### Comments  Co-authored-by: Mel McCann <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 17, 2020
2385: Upload swagger to bump.sh on release deployment r=piotr-iohk a=piotr-iohk # Issue Number ADP-600 <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview - 275956f Upload swagger upload to bump.sh on release - ca0d72f Add API Changes section in Release template # Comments - I have tested upload from Travis into bump.sh -> https://bump.sh/doc/cardano-wallet-test/changes ✔️ - swagger should be uploaded to https://bump.sh/doc/cardano-wallet-diff/changes on release deploy step - added `API Changes` section to release template with a note 2398: Update docker compose with Allegra compatible tags r=rvl a=melmccann Update docker compose to reflect the Allegra docker compatible versions Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Mel McCann <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 18, 2020
2385: Upload swagger to bump.sh on release deployment r=piotr-iohk a=piotr-iohk # Issue Number ADP-600 <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview - 275956f Upload swagger upload to bump.sh on release - ca0d72f Add API Changes section in Release template # Comments - I have tested upload from Travis into bump.sh -> https://bump.sh/doc/cardano-wallet-test/changes ✔️ - swagger should be uploaded to https://bump.sh/doc/cardano-wallet-diff/changes on release deploy step - added `API Changes` section to release template with a note 2404: Update docker-compose from make_release.sh r=piotr-iohk a=piotr-iohk # Issue Number #2398 # Overview - e02d604 Update docker-compose from make_release.sh # Comments Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docker compose to reflect the Allegra docker compatible versions